Skip to content

🌱 Add SetLogger to e2e tests #2143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

🌱 Add SetLogger to e2e tests #2143

wants to merge 3 commits into from

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Aug 11, 2025

Downstream is complaining of missing SetLogger call in the e2e.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort
Add SetLogger to e2e tests
84b4f20 
Downstream is complaining of missing `SetLogger` call in the e2e.
@tmshort tmshort requested a review from a team as a code owner August 11, 2025 22:36
@netlify
Copy link

netlify bot commented Aug 11, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 781cd7a
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/689ab21042da990008f329b7
😎 Deploy Preview https://deploy-preview-2143--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested review from bentito and dtfranz August 11, 2025 22:36
@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.77%. Comparing base (a62ff79) to head (781cd7a).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2143      +/-   ##
==========================================
+ Coverage   72.75%   72.77%   +0.02%     
==========================================
  Files          79       79              
  Lines        7340     7340              
==========================================
+ Hits         5340     5342       +2     
+ Misses       1653     1652       -1     
+ Partials      347      346       -1
Flag Coverage Δ
e2e 44.38% <ø> (+0.09%) ⬆️
experimental-e2e 54.96% <ø> (+0.04%) ⬆️
unit 58.21% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort tmshort closed this Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bentito bentito Awaiting requested review from bentito

@dtfranz dtfranz Awaiting requested review from dtfranz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tmshort